-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rdkafka-sys): update librdkafka to v2.1.1 #579
feat(rdkafka-sys): update librdkafka to v2.1.1 #579
Conversation
@davidblewett is this something that could get some eyes? The version of librdkafka is a bit old and updating would help the library I think. |
@wmorgan6796 we are interested in updated librdkafka soon, yes. We were waiting on confluentinc/librdkafka#4171 to be included in a release first and updating to that. |
We are also affected by karafka/rdkafka-ruby#254 (comment) , which should be address in |
@davidblewett yeah since you're going for 2.1.1 you may as well wait for 2.2.0 ;) FYI I have an extensive integration suite for librdkafka, so you can also watch the issue you mentioned for updates. Once I run them and stable I will close this issue. |
@mensfeld do you know if there's a tracking issue for the release of |
@abrisco just the discussion: confluentinc/librdkafka#4314 |
The version 2.2.0 has been released yesterday: https://github.com/confluentinc/librdkafka/releases/tag/v2.2.0 ⭐ |
@jaudiger and it is stable. I can no longer reproduce this on my side in Ruby. |
@jaudiger nvmd I still see it 😢 and I can reproduce it with 2.2.0 |
Hi, just popping into mention that I've been waiting for this to land and i'm hoping we can go ahead with a release containing 2.1.1 or 2.2.0 |
Hi, Is there any insight available regarding the timeline for the release of this upgrade ? Are there any challenges that could potentially impact the advancement of this initiative? |
@dertin 2.2.0 does not fully fix this. A more complex fix or rather mitigation with rebalance state tracking is needed. @davidblewett feel free to ping me for a more extensive explanation if you need. |
@mensfeld I recall seeing some updates from you along those lines. Can you point me to what is needed to implement the mitigation? I'm not sure I will have the cycles to implement it, but it will help move the ball forward. |
I should have just pasted this: https://github.com/karafka/karafka/pull/1524/files You need to track the rebalance state via the rebalane cb and not close the client until first rebalance at least starts. Otherwise 2.2.0 will crash as rb handler is null but that ain't checked. Fix is already implemented but not considered critical so not released. |
Close this in favor of updating to v2.2.0: #603 . |
Updating librdkafka to latest release. This also allows for usage of openssl 3.0, but upgrading openssl-sys felt like outside the scope of this PR.